src/pages/academy/grading/subcomponents/GradingSubmissionsTable.tsx (2)

3-3: Use type-only imports for AG Grid types

Import ColDef and CellClickedEvent as types to avoid bringing type-only symbols into the runtime bundle and to stay consistent with the rest of the PR.

-import { CellClickedEvent, ColDef, themeQuartz } from 'ag-grid-community';
+import { type CellClickedEvent, type ColDef, themeQuartz } from 'ag-grid-community';

---

421-434: Type safety for filter model parsing

cellFilters is currently untyped and key is a string. Tighten the types to match ColumnFields and guard the filter value.

-            const cellFilters = [];
-            for (const [key, { filter: query }] of Object.entries(filters)) {
+            const cellFilters: { id: ColumnFields; value: string }[] = [];
+            for (const [key, { filter: query } as any] of Object.entries(filters)) {
               switch (key) {
                 // Fields that BE supports filtering on
                 case ColumnFields.studentName:
                 case ColumnFields.studentUsername:
                 case ColumnFields.groupName:
-                  cellFilters.push({ id: key, value: query });
+                  cellFilters.push({ id: key as ColumnFields, value: String(query ?? '') });
                   break;
               }
             }

src/commons/sourceRecorder/SourceRecorderTable.tsx (1)

9-9: Nit: use type-only imports for AG Grid types for consistency

For consistency with other files in this PR (and to avoid runtime imports of types), consider switching to type-only imports.

-import { ColDef, GridApi, GridReadyEvent } from 'ag-grid-community';
+import { type ColDef, type GridApi, type GridReadyEvent } from 'ag-grid-community';

src/pages/leaderboard/subcomponents/ContestLeaderboard.tsx (1)

175-178: Minor: Pagination condition on Top 3 grid is never true

top3 has at most 3 rows, so pagination={top3.length > 10} is always false. Drop pagination props for clarity.

-          pagination={top3.length > 10}
-          paginationPageSize={10}
-          paginationPageSizeSelector={[10]}
+          pagination={false}

src/pages/stories/StoriesTable.tsx (1)

3-3: Nit: import ColDef as a type-only import for consistency and bundle hygiene

Matches the pattern used elsewhere in this PR.

-import { ColDef, themeQuartz } from 'ag-grid-community';
+import { type ColDef, themeQuartz } from 'ag-grid-community';

src/routes/routerConfig.ts (1)

98-106: Confirm redirect status semantics

I didn’t find any other redirect(…, { status: … }) calls or usages of a 401 status in the repo. If you intentionally dropped the 401 and are fine with the default 302 for unauthenticated users, no further changes are needed. Otherwise, to preserve “unauthorized” semantics in SSR, analytics or error-boundary logic, restore the explicit 401:

-      return redirect('/login');
+      return redirect('/login', { status: 401 });

src/index.tsx (1)

14-20: Centralized bootstrapping looks good

Calling initializeSentryLogging and initializeAgGridModules at startup is the right place to ensure both are configured before any routes or grids mount.

Minor: during HMR these can run more than once; ensure the initializers are idempotent (ModuleRegistry is tolerant, and Sentry.init is safe when DSN is unset, but guarding can reduce console noise).

src/bootstrap/agGrid.ts (2)

18-31: Don’t include ValidationModule in production bundle

ValidationModule is meant for development diagnostics. It’s already conditionally added below for development; including it in productionModules bloats the production bundle and can double-register the module.

Remove it from productionModules:

 const productionModules: readonly Module[] = [
   CellStyleModule,
   ClientSideRowModelModule,
   ColumnApiModule,
   ColumnAutoSizeModule,
   CsvExportModule,
   DateFilterModule,
   InfiniteRowModelModule,
   PaginationModule,
   RowDragModule,
   TextEditorModule,
-  TextFilterModule,
-  ValidationModule
+  TextFilterModule
 ];

---

33-41: Optional: guard against duplicate registration during HMR

ModuleRegistry.registerModules is idempotent, but in dev HMR can cause repeated calls and noisy logs. You can add a simple guard:

 export const initializeAgGridModules = () => {
-  const modulesToLoad = [...productionModules];
+  // Avoid duplicate registration during HMR/dev
+  if (typeof window !== 'undefined' && (window as any).__AG_GRID_MODULES_REGISTERED__) {
+    return;
+  }
+  const modulesToLoad = [...productionModules];
@@
   ModuleRegistry.registerModules(modulesToLoad);
+  if (typeof window !== 'undefined') {
+    (window as any).__AG_GRID_MODULES_REGISTERED__ = true;
+  }
 };

src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx (2)

320-323: Make row updates robust under reordering with getRowId

Index-based updates can desync after drag reordering. Provide stable row IDs so the grid and your state reconcile reliably.

Apply within this component:

-        <AgGridReact
+        <AgGridReact
+          getRowId={params => String(params.data.assessmentConfigId)}
           theme={themeBalham}

This avoids relying on rowIndex when calling setDataValue or handling drag moves.

---

3-9: Verified themeBalham in ag-grid-community v34.1.1 + optional centralization
themeBalham is exported in your installed version (^34.1.1) and in use alongside themeAlpine and themeQuartz across the app. No breaking imports detected. To keep themes consistent, you may optionally centralize theme selection:

• Major usages:
– src/pages/stories/StoriesTable.tsx (themeQuartz)
– src/pages/leaderboard/subcomponents/OverallLeaderboard.tsx (themeAlpine)
– src/pages/academy/dashboard/Dashboard.tsx (themeBalham)
– …and ~10 more components under src/pages/academy/adminPanel and commons

Suggested refactor (optional):
• Create a single module (e.g. src/config/agGridTheme.ts) exporting your default theme constant, and import that everywhere instead of importing raw theme* values.

src/pages/academy/academyRoutes.ts (1)

10-13: Loader location/naming

Importing loaders from ../leaderboard/subcomponents/leaderboardUtils blurs responsibilities. Consider moving them to a non-UI module (e.g., ../leaderboard/loaders or ../leaderboard/routes) to better separate routing/data from presentation.

src/pages/leaderboard/subcomponents/leaderboardUtils.ts (2)

11-15: Avoid dynamic RegExp from variable input; use exact path comparison

A regex built from variable input can be fragile and is flagged by static analysis. You don’t need regex here; exact path equality is sufficient and safer.

Apply this diff:

-  const rootRegex = new RegExp(`^${baseUrl}/leaderboard/?$`);
-  if (!rootRegex.test(path)) {
+  const isRoot = path === `${baseUrl}/leaderboard` || path === `${baseUrl}/leaderboard/`;
+  if (!isRoot) {
     // Don't try to redirect subpaths, pass through and proceed
     return null;
   }

---

10-10: Typo in comment

Minor nit: “If if it” -> “If it is”.

Apply this diff:

-  // If if it a sub-path, pass through transparently
+  // If it is a sub-path, pass through transparently

src/pages/leaderboard/subcomponents/OverallLeaderboard.tsx (3)

46-53: Use width instead of flex on the avatar image

flex: '40px' on an img is odd and likely unintended. Use a fixed width for the avatar.

Apply this diff:

-        style={{ flex: '40px', height: '40px', borderRadius: '50%' }}
+        style={{ width: 40, height: 40, borderRadius: '50%' }}

---

28-57: Prefer typing cell renderer params

The any typing in cellRenderers loses safety and IntelliSense. AG Grid provides renderer param types.

Example:

import type { ICellRendererParams, ValueGetterParams } from 'ag-grid-community';
// ...
cellRenderer: (params: ICellRendererParams<LeaderboardRow, number>) => { /* ... */ }

---

17-26: Seed function slices the first char; confirm it’s intended for usernames

convertToRandomNumber slices off the first character (id.slice(1)). This made sense if IDs had a prefix (e.g., S123), but you’re now passing row.username. If usernames don’t have a known prefix, slicing could reduce entropy and cause collisions.

If unnecessary, consider:

-  const str = id.slice(1);
+  const str = id;

Or document the assumption about the first character in a comment.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.